-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose deserialize convenience methods #257
Conversation
Thank you for the PR! |
I re-exported them as they fit the way I do not see any real benefit from not re-exporting the methods. Re-exporting them is similar to a |
I've read and did some more research about The layout should look like this in basic scenarios: mod de;
mod error;
mod ser;
pub use de::{from_str, Deserializer};
pub use error::{Error, Result};
pub use ser::{to_string, Serializer}; According to this:
The Additionally:
This would apply for all Given that those are somewhat
|
Thank you for writing this down! A backwards-compatible version of this PR would need to be made against v0.6 branch, with an extra commit that appends to the CHANGELOG and bumps the patch version. This is where we publish from. |
I made |
Please make the CI happy |
Should be done. However, |
Issue has had no activity in the last 60 days and is going to be closed in 7 days if no further activity occurs |
comment |
These methods are exposed now, so I'm closing this PR. Feel free to reopen if there's something I missed. |
Weirdly enough, the methods were already implemented but not exposed by the root module (
ron
). They could only be accessed by going throughron::{de, se}
, which made me believe that they do not exist.This PR adds them to the root module to make discovery easier.
Fixes #255.